-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split config and genesis to client config and chain spec #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
yangby-cryptape
force-pushed
the
yangby/refactor/split-configs
branch
3 times, most recently
from
August 17, 2023 07:57
0e45800
to
6e6ca2b
Compare
yangby-cryptape
requested review from
jjyr,
ashuralyk,
Flouse,
blckngm,
driftluo and
KaoImin
and removed request for
jjyr and
ashuralyk
August 17, 2023 08:10
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
KaoImin
reviewed
Aug 18, 2023
KaoImin
reviewed
Aug 18, 2023
KaoImin
reviewed
Aug 18, 2023
yangby-cryptape
force-pushed
the
yangby/refactor/split-configs
branch
from
August 18, 2023 03:41
6e6ca2b
to
b2ad2d7
Compare
Flouse
reviewed
Aug 18, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Aug 18, 2023
Flouse
approved these changes
Aug 18, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR split current config (
config.toml
) and genesis (genesis.json
) into 2 parts:Axon client configuration file (
config.toml
).All parameters in the client configuration can be modified after chain initialized, and the chain won't be affected by their changes.
❓ Is there any other parameters in
config.toml
can affect the consensus?The chain specification (
chain-spec.toml
andgenesis_transactions.json
).All parameters in the chain specification are not allowed to be modified after the chain initialized.
Any changes of the chain specification will make the chain to be a different chain.
👉 A template of the chain specification:
The "params" section is empty now, so current PR is consensus compatible.
In nearly future,
contract_size_limit
can be added into "params" section.❓ Any other fields for genesis block should be configurable?
What is the impact of this PR?
Breaking Change:
run
command are changed:--genesis
is removed.--chain-spec
replaces--genesis
.run
command are changed.accounts
section is removed from configuration file.Special notes for your reviewer:
NIL
PR relation:
config.toml
, split the consensus parameters. #1307CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc