refactor: change config to single struct #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
changed the title
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
from
bca4586 to
0f2b30b
Compare
driftluo
changed the title
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
2 times, most recently
from
32b525a to
a9c4116
Compare
Flouse
requested review from
KaoImin
and removed request for
ahonn and
Simon-Tl
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
from
a9c4116 to
96cb8e2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
3 times, most recently
from
6bcc73d to
5cf2425
Compare
|
/run-ci |
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
from
5cf2425 to
35821a3
Compare
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
from
35821a3 to
2f57c95
Compare
driftluo
force-pushed
the
change-metadata-config-to-single-struct
branch
from
2f57c95 to
1ffe169
Compare
|
/run-ci |
KaoImin
approved these changes
Aug 23, 2023
yangby-cryptape
approved these changes
Aug 23, 2023
Flouse
approved these changes
Aug 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
<!-- Thanks for sending a pull request! --> ## What this PR does / why we need it? This PR fixes genesis hash change on #1328 ### What is the impact of this PR? No Breaking Change <!-- **Special notes for your reviewer**: NIL **PR relation**: - Ref # **Which issue(s) this PR fixes**: You could link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. - Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. see [Linking a pull request to an issue using a keyword](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) or [Manually linking a pull request to an issue using the pull request sidebar](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-or-branch-to-an-issue-using-the-issue-sidebar) --> <details><summary>CI Settings</summary><br/> <!-- Have I run `make ci`? --> ### **CI Usage** **Tip**: Check the CI you want to run below, and then comment `/run-ci`. **CI Switch** - [ ] Cargo Clippy - [ ] Coverage Test - [ ] E2E Tests - [ ] Code Format - [ ] Unit Tests - [ ] Web3 Compatible Tests - [ ] OCT 1-5 And 12-15 - [ ] OCT 6-10 - [ ] OCT 11 - [ ] OCT 16-19 - [ ] v3 Core Tests ### **CI Description** | CI Name | Description | | ----------------------------------------- | ------------------------------------------------------------------------- | | *Chaos CI* | Test the liveness and robustness of Axon under terrible network condition | | *Cargo Clippy* | Run `cargo clippy --all --all-targets --all-features` | | *Coverage Test* | Get the unit test coverage report | | *E2E Test* | Run end-to-end test to check interfaces | | *Code Format* | Run `cargo +nightly fmt --all -- --check` and `cargo sort -gwc` | | *Web3 Compatible Test* | Test the Web3 compatibility of Axon | | *v3 Core Test* | Run the compatibility tests provided by Uniswap V3 | | *OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19* | Run the compatibility tests provided by OpenZeppelin | <!-- #### Deprecated CIs - [ ] Chaos CI --> </details>
KaoImin
pushed a commit
that referenced
this pull request
Aug 25, 2023
KaoImin
pushed a commit
that referenced
this pull request
Aug 25, 2023
<!-- Thanks for sending a pull request! --> ## What this PR does / why we need it? This PR fixes genesis hash change on #1328 ### What is the impact of this PR? No Breaking Change <!-- **Special notes for your reviewer**: NIL **PR relation**: - Ref # **Which issue(s) this PR fixes**: You could link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. - Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. see [Linking a pull request to an issue using a keyword](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) or [Manually linking a pull request to an issue using the pull request sidebar](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-or-branch-to-an-issue-using-the-issue-sidebar) --> <details><summary>CI Settings</summary><br/> <!-- Have I run `make ci`? --> ### **CI Usage** **Tip**: Check the CI you want to run below, and then comment `/run-ci`. **CI Switch** - [ ] Cargo Clippy - [ ] Coverage Test - [ ] E2E Tests - [ ] Code Format - [ ] Unit Tests - [ ] Web3 Compatible Tests - [ ] OCT 1-5 And 12-15 - [ ] OCT 6-10 - [ ] OCT 11 - [ ] OCT 16-19 - [ ] v3 Core Tests ### **CI Description** | CI Name | Description | | ----------------------------------------- | ------------------------------------------------------------------------- | | *Chaos CI* | Test the liveness and robustness of Axon under terrible network condition | | *Cargo Clippy* | Run `cargo clippy --all --all-targets --all-features` | | *Coverage Test* | Get the unit test coverage report | | *E2E Test* | Run end-to-end test to check interfaces | | *Code Format* | Run `cargo +nightly fmt --all -- --check` and `cargo sort -gwc` | | *Web3 Compatible Test* | Test the Web3 compatibility of Axon | | *v3 Core Test* | Run the compatibility tests provided by Uniswap V3 | | *OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19* | Run the compatibility tests provided by OpenZeppelin | <!-- #### Deprecated CIs - [ ] Chaos CI --> </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR change metadata config to a single struct, this is a break change
Which docs this PR relation:
Which toolchain this PR adaption:
!!Breaking Change!!
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch