Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change the position of signature hash in interoperation verify #1316

Merged
merged 4 commits into from
Aug 11, 2023
Merged

refactor: change the position of signature hash in interoperation verify #1316

merged 4 commits into from
Aug 11, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Aug 10, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it:

This PR fix always success cell init

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@driftluo driftluo requested a review from a team as a code owner August 10, 2023 03:44
@driftluo driftluo requested review from jjyr and felicityin August 10, 2023 03:44
@driftluo driftluo requested review from KaoImin and yangby-cryptape and removed request for jjyr and felicityin August 10, 2023 03:45
@KaoImin
Copy link
Contributor

KaoImin commented Aug 10, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 10, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

KaoImin
KaoImin previously approved these changes Aug 10, 2023
View reviewed changes
@KaoImin KaoImin self-requested a review August 10, 2023 07:37
@KaoImin
Copy link
Contributor

KaoImin commented Aug 10, 2023

hold

@KaoImin KaoImin changed the title fix: fix always success cell init refactor: change the position of signature hash in interoperation verify Aug 10, 2023
@KaoImin KaoImin requested a review from Flouse August 11, 2023 06:58
@KaoImin
Copy link
Contributor

KaoImin commented Aug 11, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 11, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin force-pushed the fix-always-success-cell-init branch from 98923ab to 4fbfc16 Compare August 11, 2023 08:54
@KaoImin
Copy link
Contributor

KaoImin commented Aug 11, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 11, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

Flouse
Flouse approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaoImin KaoImin added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit b8b7720 Aug 11, 2023
@driftluo driftluo deleted the fix-always-success-cell-init branch August 11, 2023 16:26
KaoImin added a commit that referenced this pull request Aug 25, 2023
@driftluo @KaoImin
refactor: change the position of signature hash in interoperation ver…
d7cfac0 
…ify (#1316)

Co-authored-by: Eason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@Flouse Flouse Flouse approved these changes

@KaoImin KaoImin Awaiting requested review from KaoImin

Assignees
No one assigned
Labels
bugfix refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driftluo @KaoImin @Flouse @yangby-cryptape