Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get client version from crate and git #1309

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Aug 7, 2023

What this PR does / why we need it:

This PR

  1. Get the client version from crate version and git such as 0.1.0-beta.5+8f3eded
  2. Remove the client_version field in config.rpc

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner August 7, 2023 11:12
@KaoImin KaoImin requested review from jjyr and blckngm August 7, 2023 11:12
@KaoImin KaoImin force-pushed the fix-client-version branch from 15d8b4d to 24341ea Compare August 7, 2023 11:13
@KaoImin KaoImin requested review from Flouse and yangby-cryptape and removed request for jjyr August 7, 2023 11:14
@KaoImin
Copy link
Contributor Author

KaoImin commented Aug 7, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 7, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
core/cli/src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
core/cli/src/lib.rs Outdated Show resolved Hide resolved
blckngm
blckngm previously approved these changes Aug 15, 2023
Flouse

This comment was marked as resolved.

@Flouse
Copy link
Contributor

Flouse commented Aug 15, 2023

/run-ci

@axon-bot

This comment was marked as outdated.

Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

curl --location --request POST 'http://localhost:8000' \
--header 'Content-Type: application/json' \
--header 'Accept: */*' \
--data-raw '{
    "id": 42,
    "jsonrpc": "2.0",
    "method": "web3_clientVersion",
    "params": []
}'

{"jsonrpc":"2.0","result":"0.1.0-beta.5+5ef98b4","id":42}

Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaoImin KaoImin force-pushed the fix-client-version branch from 954877e to 3292b5a Compare August 15, 2023 10:42
@KaoImin KaoImin requested a review from Flouse August 15, 2023 10:42
@KaoImin

This comment was marked as off-topic.

@KaoImin KaoImin requested a review from blckngm August 15, 2023 10:42
@axon-bot
Copy link

axon-bot bot commented Aug 15, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin enabled auto-merge August 16, 2023 01:37
@KaoImin KaoImin added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 90b81b6 Aug 16, 2023
@KaoImin KaoImin deleted the fix-client-version branch August 16, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants