-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: get client version from crate and git #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
force-pushed
the
fix-client-version
branch
from
August 7, 2023 11:13
15d8b4d
to
24341ea
Compare
KaoImin
requested review from
Flouse and
yangby-cryptape
and removed request for
jjyr
August 7, 2023 11:14
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
blckngm
reviewed
Aug 7, 2023
blckngm
reviewed
Aug 7, 2023
KaoImin
force-pushed
the
fix-client-version
branch
from
August 7, 2023 13:39
eeb04e6
to
e298ecc
Compare
blckngm
reviewed
Aug 7, 2023
blckngm
reviewed
Aug 7, 2023
blckngm
previously approved these changes
Aug 15, 2023
/run-ci |
This comment was marked as outdated.
This comment was marked as outdated.
Flouse
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
curl --location --request POST 'http://localhost:8000' \
--header 'Content-Type: application/json' \
--header 'Accept: */*' \
--data-raw '{
"id": 42,
"jsonrpc": "2.0",
"method": "web3_clientVersion",
"params": []
}'
{"jsonrpc":"2.0","result":"0.1.0-beta.5+5ef98b4","id":42}
Flouse
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KaoImin
force-pushed
the
fix-client-version
branch
from
August 15, 2023 10:42
954877e
to
3292b5a
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Aug 15, 2023
blckngm
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR
0.1.0-beta.5+8f3eded
client_version
field inconfig.rpc
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc
CI Usage
CI Switch