fix: no default values when unexpected errors occurred #1303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR:
Remove
unwrap_or_default
for unexpected errors.Set default value directly instead of
unwrap_or_default
.const fn for traits
is not released (today, latest toolchain is1.71.0
), set a const value withunwrap_or(const_value)
is better thanunwrap_or_default
, sinceunwrap_or_default
will call theDefault::default(..)
function.p.s.
-O3
, even-O2
, may ignore the call, set const value directly.More readability, a literal value is more clearly than
Default::default(..)
.Which issue(s) this PR fixes:
Fixes #1287
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc
CI Usage
CI Switch