Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(precompile): call ckb vm and verify by ckb payload #1285

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Jul 28, 2023

What this PR does / why we need it:

This PR change the payloads of call CKB vm and verify by CKB precompile contracts into EthAbiCodec derive. The old version is defined by rlp.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner July 28, 2023 03:27
@KaoImin KaoImin requested review from jjyr and ashuralyk July 28, 2023 03:27
@KaoImin
Copy link
Contributor Author

KaoImin commented Jul 30, 2023

ping @yangby-cryptape

Copy link
Collaborator

@yangby-cryptape yangby-cryptape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those new code covered by any tests?

@KaoImin KaoImin force-pushed the refactor-precompile-input branch from a248c56 to 09683ce Compare August 3, 2023 02:45
@Flouse Flouse requested review from driftluo and removed request for ashuralyk August 3, 2023 04:19
@KaoImin KaoImin force-pushed the refactor-precompile-input branch from 09683ce to c9bcba1 Compare August 4, 2023 02:46
@KaoImin KaoImin force-pushed the refactor-precompile-input branch 3 times, most recently from bf74471 to 3f52364 Compare August 25, 2023 03:36
@KaoImin KaoImin requested review from felicityin and yangby-cryptape and removed request for jjyr August 25, 2023 03:37
@KaoImin KaoImin force-pushed the refactor-precompile-input branch from 3f52364 to e3cdf2f Compare August 31, 2023 09:32
@KaoImin KaoImin enabled auto-merge August 31, 2023 10:11
@KaoImin KaoImin added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 6b9b243 Aug 31, 2023
24 checks passed
@KaoImin KaoImin deleted the refactor-precompile-input branch September 1, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants