-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(precompile): call ckb vm and verify by ckb payload #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping @yangby-cryptape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those new code covered by any tests?
KaoImin
force-pushed
the
refactor-precompile-input
branch
from
August 3, 2023 02:45
a248c56
to
09683ce
Compare
KaoImin
force-pushed
the
refactor-precompile-input
branch
from
August 4, 2023 02:46
09683ce
to
c9bcba1
Compare
KaoImin
force-pushed
the
refactor-precompile-input
branch
3 times, most recently
from
August 25, 2023 03:36
bf74471
to
3f52364
Compare
KaoImin
requested review from
felicityin and
yangby-cryptape
and removed request for
jjyr
August 25, 2023 03:37
driftluo
approved these changes
Aug 25, 2023
KaoImin
force-pushed
the
refactor-precompile-input
branch
from
August 31, 2023 09:32
3f52364
to
e3cdf2f
Compare
felicityin
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR change the payloads of call CKB vm and verify by CKB precompile contracts into
EthAbiCodec
derive. The old version is defined byrlp
.Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc
CI Usage
CI Switch