-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(executor): thread local instead of global variable #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
requested review from
blckngm,
driftluo and
yangby-cryptape
and removed request for
jjyr and
ashuralyk
July 21, 2023 03:42
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
changed the title
refactor: thread local instead of global variable
refactor(executor): thread local instead of global variable
Jul 21, 2023
blckngm
previously approved these changes
Jul 21, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
force-pushed
the
remove-system-contract-global-varible
branch
from
July 24, 2023 07:12
e2eed10
to
dff856c
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
blckngm
previously approved these changes
Jul 25, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
previously approved these changes
Aug 1, 2023
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
previously approved these changes
Aug 2, 2023
yangby-cryptape
previously approved these changes
Aug 2, 2023
Flouse
previously approved these changes
Aug 2, 2023
KaoImin
changed the title
refactor(executor): thread local instead of global variable
[WIP]refactor(executor): thread local instead of global variable
Aug 2, 2023
KaoImin
dismissed stale reviews from Flouse, yangby-cryptape, and driftluo
via
August 2, 2023 04:34
c158a57
KaoImin
force-pushed
the
remove-system-contract-global-varible
branch
from
August 2, 2023 04:34
1381b65
to
c158a57
Compare
KaoImin
changed the title
[WIP]refactor(executor): thread local instead of global variable
refactor(executor): thread local instead of global variable
Aug 2, 2023
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
yangby-cryptape
approved these changes
Aug 2, 2023
driftluo
approved these changes
Aug 2, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR:
Divide the global variable of system contract roots (header cell root and metadata root) into two parts:
exec()
function. The local keys are loaded at the start of execution, and the life cycle is the exec() function. It is use for transactions execution. It is use for transactions executions.Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #1278
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc
CI Usage
CI Switch