Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): the sub-command is useless #1269

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Jul 12, 2023

What this PR does / why we need it:

This PR fixes the useless sub-command run.

Currently, no matter the sub-command is provided or not, the axon always runs.

I fix this so that I could add more sub-commands later.

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@yangby-cryptape

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@yangby-cryptape

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape force-pushed the yangby/bugfix/subcommands branch from 3131560 to 7c44a0e Compare July 13, 2023 02:43
@yangby-cryptape

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@yangby-cryptape

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review July 13, 2023 07:22
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner July 13, 2023 07:22
@Flouse Flouse requested review from KaoImin and removed request for Simon-Tl July 13, 2023 10:32
@KaoImin KaoImin added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 097809e Jul 14, 2023
@KaoImin KaoImin deleted the yangby/bugfix/subcommands branch July 14, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants