Skip to content

add pytorch 2.12 base and prune unused base images#3697

Merged
winglian merged 2 commits into
mainfrom
pytorch-2120
Jun 1, 2026
Merged

add pytorch 2.12 base and prune unused base images#3697
winglian merged 2 commits into
mainfrom
pytorch-2120

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Jun 1, 2026

Description

Motivation and Context

How has this been tested?

AI Usage Disclaimer

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

  • Chores
    • Updated build configuration dependencies to support newer versions of Python, PyTorch, and GPU support frameworks for Docker image generation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdc98453-3677-4e3e-98d9-c0243058ff69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

GitHub Actions CI workflow matrix for Docker base image builds is updated to use Python 3.12 for CUDA 12.8.1 and newer PyTorch versions (2.10.0 and 2.12.0) for CUDA 13.0.0 across build-base and build-base-uv jobs.

Changes

Base Image Build Configuration

Layer / File(s) Summary
Docker build matrix dependency updates
.github/workflows/base.yml
CUDA 12.8.1 matrix entry switches to Python 3.12; CUDA 13.0.0 entries in both build-base and build-base-uv jobs are updated to use PyTorch 2.10.0 and 2.12.0 respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • axolotl-ai-cloud/axolotl#3221: Both PRs modify the same .github/workflows/base.yml build-base/build-base-uv matrix entries for CUDA 12.8.1 and Python/PyTorch versions.
  • axolotl-ai-cloud/axolotl#3429: Both PRs update .github/workflows/base.yml CUDA 13.0.0 matrix entries to target PyTorch 2.10.0 on Python 3.12.
  • axolotl-ai-cloud/axolotl#3621: Both PRs modify .github/workflows/base.yml build-base-uv entries for CUDA 13.0.0 to update PyTorch versions.

Suggested labels

ready to merge

Suggested reviewers

  • NanoCode012
  • salmanmohammadi
  • djsaunde
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: adding PyTorch 2.12 support and pruning unused base images from the Docker workflow matrix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pytorch-2120

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian merged commit 6da2f9e into main Jun 1, 2026
33 of 34 checks passed
@winglian winglian deleted the pytorch-2120 branch June 1, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant