fix(yaml): add cce and liger to nemotron-h example#3573
Conversation
📝 WalkthroughWalkthroughTwo Nemotron LoRA YAML configuration files were updated to enable Axolotl plugins (CutCrossEntropyPlugin and LigerPlugin) with corresponding feature toggles, remove the legacy Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/nemotron-h/120b-a12b-qlora.yaml`:
- Around line 3-5: The YAML registers CutCrossEntropyPlugin but never sets the
toggle it relies on, so pre_model_load's check (if cfg.cut_cross_entropy)
prevents the plugin from activating; add the top-level config key
cut_cross_entropy: true in this YAML (alongside the existing plugins list) so
CutCrossEntropyPlugin will detect cfg.cut_cross_entropy and apply its patches as
intended.
In `@examples/nemotron-h/nano-30b-a3b-qlora.yaml`:
- Around line 4-6: The config registers CutCrossEntropyPlugin but doesn't enable
it; add the feature toggle cut_cross_entropy: true at the top-level of the YAML
(next to the plugins list) so
axolotl.integrations.cut_cross_entropy.CutCrossEntropyPlugin is actually
activated and CCE patching is applied; ensure the key is present and set to true
in this and the other example config files that register the plugin.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: db64f520-029f-468c-8a55-e6acc895fd37
📒 Files selected for processing (2)
examples/nemotron-h/120b-a12b-qlora.yamlexamples/nemotron-h/nano-30b-a3b-qlora.yaml
Description
Motivation and Context
How has this been tested?
AI Usage Disclaimer
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit