Skip to content

Revert "feat: move to uv first"#3544

Merged
NanoCode012 merged 1 commit into
axolotl-ai-cloud:mainfrom
NanoCode012:fix/accident-uv-push
Mar 25, 2026
Merged

Revert "feat: move to uv first"#3544
NanoCode012 merged 1 commit into
axolotl-ai-cloud:mainfrom
NanoCode012:fix/accident-uv-push

Conversation

@NanoCode012
Copy link
Copy Markdown
Collaborator

@NanoCode012 NanoCode012 commented Mar 25, 2026

This reverts commit 1f1ebb8.

Description

Changes accidentally pushed to main branch (IDE seems unclear on git publish). This PR reverts it while we get lock file tested.

Motivation and Context

How has this been tested?

AI Usage Disclaimer

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

  • Chores
    • Restructured dependency management system to use dynamic resolution during build process, moving dependency specifications from configuration files to runtime-determined requirements.
    • Updated CI/CD workflows to monitor dependency file changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a6a82afb-f459-42d0-8c33-b0e1a91bc0a3

📥 Commits

Reviewing files that changed from the base of the PR and between 1f1ebb8 and 49568fa.

📒 Files selected for processing (9)
  • .github/workflows/lint.yml
  • .github/workflows/multi-gpu-e2e.yml
  • .github/workflows/tests-nightly.yml
  • .github/workflows/tests.yml
  • MANIFEST.in
  • pyproject.toml
  • requirements.txt
  • setup.py
  • src/setuptools_axolotl_dynamic_dependencies.py

📝 Walkthrough

Walkthrough

This PR refactors the project's dependency management system by migrating from inline dependencies in pyproject.toml to a dynamic, file-based approach using requirements.txt with custom setuptools build logic to handle environment-specific dependency resolution across different platforms and PyTorch versions.

Changes

Cohort / File(s) Summary
CI/CD Workflow Triggers
.github/workflows/lint.yml, .github/workflows/tests.yml, .github/workflows/multi-gpu-e2e.yml
Updated pull_request and push path filters to watch requirements.txt instead of pyproject.toml for triggering workflow runs.
Nightly Test Workflow
.github/workflows/tests-nightly.yml
Replaced explicit pip install step for nightly Hugging Face packages with sed rewriting of requirements.txt entries to use @main GitHub branches before standard dependency installation.
Dynamic Dependency Resolution
setup.py, src/setuptools_axolotl_dynamic_dependencies.py, requirements.txt
Introduced new dependency management infrastructure: requirements.txt with 78 pinned dependencies, setup.py with torch version detection and conditional filtering logic, and custom setuptools_axolotl_dynamic_dependencies module implementing platform- and torch-version-aware BuildPyCommand for dynamic dependency resolution at build time.
Project Configuration
pyproject.toml
Restructured to mark version, dependencies, and optional-dependencies as dynamic; removed 168 lines of inline dependency declarations; added packaging==26.0 to build requirements; configured setuptools to use dynamic dependency module; removed [tool.uv] section and build dependencies.
Package Manifest
MANIFEST.in
Added requirements.txt and setuptools_axolotl_dynamic_dependencies.py to package artifacts; removed VERSION file; added recursive inclusion of \*.py files under axolotl package.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • SalmanMohammadi
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NanoCode012 NanoCode012 merged commit 2fb7279 into axolotl-ai-cloud:main Mar 25, 2026
14 of 21 checks passed
@NanoCode012 NanoCode012 deleted the fix/accident-uv-push branch March 25, 2026 09:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot mentioned this pull request Mar 25, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant