Skip to content

Reverts commits 79908b3c6, 083c5a042, e1ff75624, ff77fa248.#3496

Merged
winglian merged 1 commit into
mainfrom
revert-uv-ubuntu
Mar 13, 2026
Merged

Reverts commits 79908b3c6, 083c5a042, e1ff75624, ff77fa248.#3496
winglian merged 1 commit into
mainfrom
revert-uv-ubuntu

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Mar 13, 2026

The non-root user approach had multiple issues with RunPod compatibility, sudo PATH handling, and tmux in exec sessions. Restoring root as the default user for now.

Description

verified this does have zero net changes
Screenshot 2026-03-13 at 11 52 57 AM

Motivation and Context

How has this been tested?

AI Usage Disclaimer

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

  • Refactor
    • Simplified container startup and initialization process
    • Streamlined entrypoint script execution and user context handling
    • Removed intermediate setup steps for more direct service initialization
    • Consolidated Docker image configuration for cleaner startup flow

The non-root user approach had multiple issues with RunPod
compatibility, sudo PATH handling, and tmux in exec sessions.
Restoring root as the default user for now.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 799eb8a3-b20c-435b-84c3-4c478c79bb33

📥 Commits

Reviewing files that changed from the base of the PR and between ff77fa2 and 85a556d.

📒 Files selected for processing (4)
  • docker/Dockerfile-cloud-uv
  • docker/Dockerfile-uv
  • docker/Dockerfile-uv-base
  • scripts/cloud-entrypoint.sh

📝 Walkthrough

Walkthrough

This PR removes the ubuntu user from Docker images across all Dockerfiles and the cloud entrypoint script, consolidating setup logic to run under the root user context. It updates script paths, adjusts home directory references, and removes sudo-dependent logic and user-switching branching.

Changes

Cohort / File(s) Summary
Docker base configuration
docker/Dockerfile-uv-base
Removes ubuntu user creation and sudo setup; adds root PATH environment variable for local binaries; simplifies UV Python installation and removes workspace ownership transfer.
Docker application images
docker/Dockerfile-uv, docker/Dockerfile-cloud-uv
Removes ubuntu user references and home directory customization; updates entrypoint script paths from /etc/ and /home/ubuntu/ to /root/; consolidates SSH and tmux configuration to target root home directory.
Cloud entrypoint script
scripts/cloud-entrypoint.sh
Removes sudo detection and RUN_AS_USER branching logic; simplifies add_keys_to_authorized() function signature (removes target_home parameter); updates SSH key setup, service startup, and Jupyter invocation to use direct execution without user context switching.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-uv-ubuntu
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@winglian winglian merged commit d8a0574 into main Mar 13, 2026
0 of 18 checks passed
@winglian winglian deleted the revert-uv-ubuntu branch March 13, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant