fix(pydantic): set allowed values for adapter config#3415
Conversation
📝 WalkthroughWalkthroughThe adapter field type in LoraConfig was narrowed from a generic string to a constrained literal type accepting only "lora", "qlora", or "llama-adapter". The field description was updated to reflect these allowed values. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📖 Documentation Preview: https://6992945d2485f04e85919b08--resonant-treacle-0fd729.netlify.app Deployed on Netlify from commit d6c4241 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adapter configadapter config
Description
From telemetry, we had users setting this to invalid values. This helps set early validation that we missed
Motivation and Context
How has this been tested?
AI Usage Disclaimer
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit