Skip to content

handle warnings from v5 upgrade#3376

Merged
winglian merged 2 commits into
mainfrom
post-v5-fixes
Jan 28, 2026
Merged

handle warnings from v5 upgrade#3376
winglian merged 2 commits into
mainfrom
post-v5-fixes

Conversation

@winglian

@winglian winglian commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores

    • Updated TRL package dependency to version 0.27.1
    • Adjusted environment variable configuration for performance optimization
  • Tests

    • Improved tokenizer fixtures with offline HuggingFace support
  • Refactor

    • Reorganized training configuration module structure for better modularity

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the trl package dependency to version 0.27.1, reorganizes imports to reference CPO, KTO, ORPO, and PRM configurations from trl.experimental submodules, modifies CLI environment variable configuration, and adds offline HuggingFace support to test fixtures.

Changes

Cohort / File(s) Summary
TRL Dependency Update
requirements.txt
Version bump from 0.27.0 to 0.27.1
TRL Imports Reorganization
src/axolotl/core/trainers/trl.py, src/axolotl/core/training_args.py
Replaced bulk trl imports with explicit imports from trl and trl.experimental submodules (CPOConfig, KTOConfig, ORPOConfig, PRMConfig now sourced from trl.experimental.*); RewardConfig remains in trl
Environment Variable Configuration
src/axolotl/cli/__init__.py
Changed runtime environment variable from HF_HUB_ENABLE_HF_TRANSFER to HF_XET_HIGH_PERFORMANCE in CLI initialization
Test Fixture Configuration
tests/prompt_strategies/conftest.py
Added @enable_hf_offline decorator to phi4_tokenizer and qwen3_tokenizer_fixture fixtures for offline HuggingFace usage

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • djsaunde
  • SalmanMohammadi
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'handle warnings from v5 upgrade' is vague and generic, using non-descriptive terms that don't convey specific information about what changes are actually made in the changeset. Provide a more specific title that describes the actual changes, such as 'Update TRL imports and environment variables for v0.27.1' or 'Migrate TRL trainer imports to experimental submodules'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jan 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian merged commit 6132a30 into main Jan 28, 2026
18 of 22 checks passed
@winglian winglian deleted the post-v5-fixes branch January 28, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant