Skip to content

use cuda 12.9.1 and add python 3.12 to base images #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winglian merged 1 commit into from
Jan 21, 2026
Merged

use cuda 12.9.1 and add python 3.12 to base images #3367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ jobs:
torch_cuda_arch_list: "7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX"
dockerfile: "Dockerfile-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "129"
cuda_version: 12.9.1
cudnn_version: ""
python_version: "3.12"
pytorch: 2.9.1
torch_cuda_arch_list: "7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX"
dockerfile: "Dockerfile-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "130"
cuda_version: 13.0.0
cudnn_version: ""
Expand All @@ -59,6 +67,14 @@ jobs:
torch_cuda_arch_list: "9.0+PTX"
dockerfile: "Dockerfile-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "130"
cuda_version: 13.0.0
cudnn_version: ""
python_version: "3.12"
pytorch: 2.9.1
torch_cuda_arch_list: "9.0+PTX"
dockerfile: "Dockerfile-base"
platforms: "linux/amd64,linux/arm64"
# - cuda: "128"
# cuda_version: 12.8.1
# cudnn_version: ""
Expand Down Expand Up @@ -141,6 +157,14 @@ jobs:
torch_cuda_arch_list: "7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX"
dockerfile: "Dockerfile-uv-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "129"
cuda_version: 12.9.1
cudnn_version: ""
python_version: "3.12"
pytorch: 2.9.1
torch_cuda_arch_list: "7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX"
dockerfile: "Dockerfile-uv-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "130"
cuda_version: 13.0.0
cudnn_version: ""
Expand All @@ -149,6 +173,14 @@ jobs:
torch_cuda_arch_list: "9.0+PTX"
dockerfile: "Dockerfile-uv-base"
platforms: "linux/amd64,linux/arm64"
- cuda: "130"
cuda_version: 13.0.0
cudnn_version: ""
python_version: "3.12"
pytorch: 2.9.1
torch_cuda_arch_list: "9.0+PTX"
dockerfile: "Dockerfile-uv-base"
platforms: "linux/amd64,linux/arm64"
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python_version: ["3.11"]
python_version: ["3.11", "3.12"]
pytorch_version: ["2.8.0", "2.9.0", "2.9.1"]
Comment on lines +57 to 58

@coderabbitai coderabbitai Bot Jan 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, let's examine the .github/workflows/tests.yml file
# Check the pytest job around line 57 and pytest-sdist around line 147
head -170 .github/workflows/tests.yml | tail -120 | cat -n

Repository: axolotl-ai-cloud/axolotl

Length of output: 5081

🏁 Script executed:

# Get more context around the specific lines
sed -n '45,75p' .github/workflows/tests.yml | cat -n

Repository: axolotl-ai-cloud/axolotl

Length of output: 1241

🏁 Script executed:

# Check the pytest-sdist job around line 147
sed -n '135,160p' .github/workflows/tests.yml | cat -n

Repository: axolotl-ai-cloud/axolotl

Length of output: 1011

🌐 Web query:

PyTorch 2.8 2.9 Python 3.12 compatibility support

💡 Result:

Short answer: Yes — PyTorch 2.8 and 2.9 include support for Python 3.12 (prebuilt wheels/binaries are provided for those releases). [1][2][3]

Sources:

  • PyTorch/FBGEMM compatibility table showing Python 3.12 for PyTorch 2.8.x and 2.9.x. [1]
  • PyTorch 2.8 release announcement. [2]
  • PyTorch 2.9 release announcement (notes include support across the 2.9 release family). [3]

If you need links to installation commands (pip/conda) for a specific OS/CUDA combo, tell me your platform and CUDA (or “CPU-only”) and I’ll fetch the exact command.

Ensure pytest-sdist job is also updated for Python 3.12 testing.

The pytest job correctly tests both Python 3.11 and 3.12 with PyTorch 2.8.0, 2.9.0, and 2.9.1 (all versions support Python 3.12). However, the pytest-sdist job currently tests only Python 3.11. Update the pytest-sdist job's matrix to include Python 3.12 for consistency and complete coverage, or document if this limitation is intentional.

🤖 Prompt for AI Agents 
In @.github/workflows/tests.yml around lines 57 - 58, Update the GitHub Actions
workflow to include Python 3.12 in the pytest-sdist job matrix: locate the
pytest-sdist job in .github/workflows/tests.yml and add "3.12" to the
python_version matrix (the matrix key and the job name pytest-sdist are the
targets); ensure the matrix mirrors the pytest job's python_version list so
pytest-sdist runs for both 3.11 and 3.12 unless there is an intentional reason
to keep it out, in which case add a comment documenting the limitation.

timeout-minutes: 20

Expand Down