Skip to content

don't build images w cuda 130 since we don't have flash attention wheels #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winglian merged 1 commit into from
Jan 3, 2026
+11 −11
Merged

don't build images w cuda 130 since we don't have flash attention wheels #3341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ jobs:
python_version: "3.11"
pytorch: 2.9.1
axolotl_extras:
- cuda: 130
cuda_version: 13.0.0
python_version: "3.11"
pytorch: 2.9.1
axolotl_extras:
# - cuda: 130
# cuda_version: 13.0.0
# python_version: "3.11"
# pytorch: 2.9.1
# axolotl_extras:
runs-on: axolotl-gpu-runner
steps:
- name: Checkout
Expand Down Expand Up @@ -98,11 +98,11 @@ jobs:
python_version: "3.11"
pytorch: 2.9.1
axolotl_extras:
- cuda: 130
cuda_version: 13.0.0
python_version: "3.11"
pytorch: 2.9.1
axolotl_extras:
# - cuda: 130
# cuda_version: 13.0.0
# python_version: "3.11"
# pytorch: 2.9.1
# axolotl_extras:
runs-on: axolotl-gpu-runner
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ RUN git lfs install --skip-repo && \
pip3 install -U --no-cache-dir pydantic==1.10.10 && \
pip3 cache purge

RUN if [ "$PYTORCH_VERSION" = "2.9.1" ] && [ "$CUDA" = "128" ] ; then \
RUN if [ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ] && [ "$CUDA" = "128" ] ; then \

@coderabbitai coderabbitai Bot Jan 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical syntax error: =~ requires double brackets in Bash.

The regex operator =~ only works with [[ (double brackets) in Bash, not with [ (single bracket/test command). This will cause a build failure or incorrect conditional evaluation.

🔎 Proposed fix 
-RUN if [ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ] && [ "$CUDA" = "128" ] ; then \
+RUN if [[ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ]] && [[ "$CUDA" = "128" ]] ; then \
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RUN if [ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ] && [ "$CUDA" = "128" ] ; then \
RUN if [[ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ]] && [[ "$CUDA" = "128" ]] ; then \
🤖 Prompt for AI Agents 
In docker/Dockerfile-base around line 54, the conditional uses the Bash regex
operator with single brackets (`[ "$PYTORCH_VERSION" =~ ... ]`) which is
invalid; replace the single-bracket test with a Bash double-bracket conditional
(`[[ "$PYTORCH_VERSION" =~ ^2\.9\.[0-9]+$ ]] && [ "$CUDA" = "128" ]`) or convert
the entire check to a POSIX-safe alternative (e.g., use grep -E on the variable)
and ensure the Dockerfile uses bash (#!/usr/bin/env bash or `SHELL
["/bin/bash","-c"]`) if relying on `[[ ... =~ ... ]]`.

wget https://github.com/mjun0812/flash-attention-prebuild-wheels/releases/download/v0.4.17/flash_attn-2.8.3+cu128torch2.9-cp311-cp311-linux_x86_64.whl; \
pip3 install --no-cache-dir flash_attn-2.8.3+cu128torch2.9-cp311-cp311-linux_x86_64.whl; \
rm flash_attn-2.8.3+cu128torch2.9-cp311-cp311-linux_x86_64.whl; \
Expand Down