Skip to content

Torch 2.9.1 base images#3268

Merged
winglian merged 2 commits into
mainfrom
torch-291-base
Nov 20, 2025
Merged

Torch 2.9.1 base images#3268
winglian merged 2 commits into
mainfrom
torch-291-base

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Nov 18, 2025

Summary by CodeRabbit

  • Chores
    • Bumped PyTorch version to 2.9.1 in build environments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

Updates PyTorch version from 2.9.0 to 2.9.1 in GitHub Actions workflow build matrix (CUDA 128 and 130 configurations) and updates the corresponding conditional check in the Dockerfile.

Changes

Cohort / File(s) Summary
PyTorch 2.9.1 version bump
.github/workflows/base.yml, docker/Dockerfile-base
Updates PyTorch version from 2.9.0 to 2.9.1 across build-base and build-base-uv workflows; updates Dockerfile-base conditional check from 2.9.0 to 2.9.1 for flash-attn installation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Simple, homogeneous version number updates applied consistently across two files
  • Minimal logic changes; straightforward string replacements in matrix entries and conditional statements

Possibly related PRs

  • #3229: Modifies the same build files (.github/workflows/base.yml and docker/Dockerfile-base) with CUDA 130 entry containing pytorch 2.9.0
  • #3223: Adds PyTorch 2.9 series to CI and Dockerfile configuration
  • #3221: Directly updates PyTorch version entries from 2.9.0 to 2.9.1 in the same workflow matrix and Dockerfile configuration

Suggested labels

ready to merge

Suggested reviewers

  • SalmanMohammadi
  • NanoCode012

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: updating PyTorch version to 2.9.1 in base Docker images across workflow configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch torch-291-base

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5f21fb and 03d56c7.

📒 Files selected for processing (2)
  • .github/workflows/base.yml (2 hunks)
  • docker/Dockerfile-base (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: PyTest from Source Dist (3.11, 2.7.1)
  • GitHub Check: PyTest from Source Dist (3.11, 2.9.0)
  • GitHub Check: PyTest (3.11, 2.9.0)
  • GitHub Check: PyTest from Source Dist (3.11, 2.8.0)
  • GitHub Check: PyTest (3.11, 2.7.1)
  • GitHub Check: PyTest (3.11, 2.8.0)
  • GitHub Check: build-base-uv (130, 13.0.0, 3.11, 2.9.1, 9.0+PTX, Dockerfile-uv-base)
  • GitHub Check: build-base (130, 13.0.0, 3.11, 2.9.1, 9.0+PTX, Dockerfile-base)
  • GitHub Check: build-base (128, 12.8.1, 3.11, 2.8.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
  • GitHub Check: build-base-uv (126, 12.6.3, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
  • GitHub Check: build-base (126, 12.6.3, 3.11, 2.7.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
  • GitHub Check: build-base-uv (128, 12.8.1, 3.11, 2.8.0, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
  • GitHub Check: build-base (126, 12.6.3, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
  • GitHub Check: build-base-uv (128, 12.8.1, 3.11, 2.7.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
  • GitHub Check: build-base-uv (128, 12.8.1, 3.11, 2.9.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-uv-base)
  • GitHub Check: build-base (128, 12.8.1, 3.11, 2.9.1, 7.0 7.5 8.0 8.6 8.7 8.9 9.0+PTX, Dockerfile-base)
🔇 Additional comments (1)
.github/workflows/base.yml (1)

60-62: LGTM! Version bump is consistent across all configurations.

The PyTorch version has been consistently updated from 2.9.0 to 2.9.1 across all matrix entries:

  • CUDA 128 and 130 configurations in build-base workflow
  • CUDA 128 and 130 configurations in build-base-uv workflow

This aligns with the corresponding update in docker/Dockerfile-base.

Also applies to: 67-69, 149-151, 156-158

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian merged commit 0d27e14 into main Nov 20, 2025
27 checks passed
@winglian winglian deleted the torch-291-base branch November 20, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants