feat(doc): update thinking and chat_template notes#3114
Conversation
📝 WalkthroughWalkthroughAdds a new documentation section "Thinking and chat_template masking conflict" to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
examples/gpt-oss/README.md (1)
109-110: Rename section for clarity and consistency.Prefer “Thinking vs chat_template masking” or “Thinking and chat_template masking conflicts” to read more naturally and match plural “conflicts.”
-### Thinking and chat_template masking conflict +### Thinking vs `chat_template` masking
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
examples/gpt-oss/README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: preview
🔇 Additional comments (1)
examples/gpt-oss/README.md (1)
113-118: Unify “thinking” terminology and bullet style-If your dataset has `thinking` content mid-turn, there are two paths we recommend: +If your dataset includes `thinking` in non-final messages, choose one of the following: -- Train only on the last turn. This can be accomplished via chat_template's [train on last doc](https://docs.axolotl.ai/docs/dataset-formats/conversation.html#training-on-last-message). +- Train only on the last message using the `chat_template` setting described here: [Training on last message](https://docs.axolotl.ai/docs/dataset-formats/conversation.html#training-on-last-message). -- Adjust your dataset to only have `thinking` content in the last turn. +- Adjust your dataset so `thinking` appears only in the final message of each conversation.
|
📖 Documentation Preview: https://68b1320c78d47547e3d27232--resonant-treacle-0fd729.netlify.app Deployed on Netlify from commit 61297e3 |
Description
Add note about mid-turn thinking.
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit