Skip to content

add bsaeten info for gpt-oss recipe#3078

Merged
winglian merged 2 commits into
mainfrom
baseten-gpt-oss
Aug 19, 2025
Merged

add bsaeten info for gpt-oss recipe#3078
winglian merged 2 commits into
mainfrom
baseten-gpt-oss

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Aug 19, 2025

Summary by CodeRabbit

  • Documentation
    • Expanded README with step-by-step guidance for Baseten-backed multi-node fine-tuning of a 120B model on 2x8xH100s.
    • Added links to Baseten’s blog post and GitHub training resources to simplify setup and replication.
    • Clarified existing ERRATA about renaming FSDP-prefixed architectures in configuration.
    • Documentation-only update; no code, public API, or behavior changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 19, 2025

📝 Walkthrough

Walkthrough

Adds detailed documentation to examples/gpt-oss/README.md describing Baseten-backed multi-node fine-tuning for the 120B model on 2×8×H100s, includes links to Baseten blog/GitHub resources, and preserves the existing ERRATA about renaming FSDP-prefixed architectures. No code or public API changes.

Changes

Cohort / File(s) Summary
Documentation update
examples/gpt-oss/README.md
Expanded README with Baseten-backed multi-node 120B fine-tuning details and external links; retained existing ERRATA note; no code or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • SalmanMohammadi

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d86e8ea and ad256f7.

📒 Files selected for processing (1)
  • examples/gpt-oss/README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
examples/gpt-oss/README.md

[grammar] ~46-~46: There might be a mistake here.
Context: ...th-baseten-and-axolotl/). The recipe can be found on their [GitHub](https://githu...

(QB_NEW_EN)


[grammar] ~47-~47: There might be a mistake here.
Context: ...lotl/). The recipe can be found on their [GitHub](https://github.com/basetenlabs/...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch baseten-gpt-oss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
examples/gpt-oss/README.md (1)

44-49: Optionally pin the GitHub link to a specific commit for reproducibility.

Pointing to “main” risks link rot or behavioral drift as the upstream evolves. Consider pinning to a permalink at a known-good commit/branch tag.

Example (replace <commit_sha> with the desired commit):

-[GitHub](https://github.com/basetenlabs/ml-cookbook/tree/main/examples/oss-gpt-120b-axolotl/training).
+[GitHub](https://github.com/basetenlabs/ml-cookbook/tree/<commit_sha>/examples/oss-gpt-120b-axolotl/training).
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c10eb81 and d86e8ea.

📒 Files selected for processing (1)
  • examples/gpt-oss/README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
examples/gpt-oss/README.md

[grammar] ~45-~45: There might be a mistake here.
Context: ...s. You can read more aboutthis recipe on [Baseten's blog](https://www.baseten.co/...

(QB_NEW_EN)


[grammar] ~46-~46: There might be a mistake here.
Context: ...th-baseten-and-axolotl/). The recipe can be found on their [GitHub](https://githu...

(QB_NEW_EN)


[grammar] ~47-~47: There might be a mistake here.
Context: ...lotl/). The recipe can be found on their [GitHub](https://github.com/basetenlabs/...

(QB_NEW_EN)

🔇 Additional comments (1)
examples/gpt-oss/README.md (1)

44-49: All external links resolve successfully (HTTP 200 OK)

Comment thread examples/gpt-oss/README.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 19, 2025

📖 Documentation Preview: https://68a47fc71ce6ac0bd9a8b83b--resonant-treacle-0fd729.netlify.app

Deployed on Netlify from commit ad256f7

Comment thread examples/gpt-oss/README.md Outdated
@winglian winglian merged commit 05cedbf into main Aug 19, 2025
3 checks passed
@winglian winglian deleted the baseten-gpt-oss branch August 19, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants