Skip to content

fix vllm tagging and add cloud images w/o tmux #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winglian merged 1 commit into from
Aug 11, 2025
Merged

fix vllm tagging and add cloud images w/o tmux #3049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ jobs:
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras:
is_latest:
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras: vllm
is_latest: true
- cuda: 128
cuda_version: 12.8.1
Expand Down Expand Up @@ -151,6 +157,18 @@ jobs:
python_version: "3.11"
pytorch: 2.6.0
axolotl_extras:
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras:
is_latest:
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras: vllm
is_latest: true
Comment on lines +160 to +171

@coderabbitai coderabbitai Bot Aug 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Same base mismatch for no-tmux: non-vllm 2.7.1 will reference a non-existent base image.

The no-tmux job includes a 2.7.1 non-vllm variant, but build-axolotl doesn’t produce the corresponding base tag. This will fail when resolving BASE_TAG.

Either add a non-vllm 2.7.1 base build in build-axolotl or remove this entry here. Minimal fix in this PR:

           - cuda: 126
             cuda_version: 12.6.3
             python_version: "3.11"
-            pytorch: 2.7.1
-            axolotl_extras:
-            is_latest:
-          - cuda: 126
-            cuda_version: 12.6.3
-            python_version: "3.11"
-            pytorch: 2.7.1
-            axolotl_extras: vllm
-            is_latest: true
+            pytorch: 2.7.1
+            axolotl_extras: vllm
+            is_latest: true

To double-check, parse the base matrix:

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail
awk '/^  build-axolotl:/{flag=1} flag && /^  [^ ]/{if ($0 !~ /^  build-axolotl:/) exit}; flag{print}' .github/workflows/main.yml \
  | sed -n '/matrix:/,/runs-on:/p' | rg -n 'pytorch:\s*2\.7\.1' -A3 -B3

Length of output: 609

Remove non-vllm PyTorch 2.7.1 entry from no-tmux matrix

The build-axolotl job only publishes a vllm variant for PyTorch 2.7.1 on CUDA 12.6.3—there is no corresponding non-vllm base image, so the current non-vllm entry will fail to resolve BASE_TAG.

• File: .github/workflows/main.yml
• Section: no-tmux job matrix (around lines 160–171)

Apply this diff:

           - cuda: 126
             cuda_version: 12.6.3
             python_version: "3.11"
-            pytorch: 2.7.1
-            axolotl_extras:
-            is_latest:
-          - cuda: 126
-            cuda_version: 12.6.3
-            python_version: "3.11"
-            pytorch: 2.7.1
-            axolotl_extras: vllm
-            is_latest: true
+            pytorch: 2.7.1
+            axolotl_extras: vllm
+            is_latest: true
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras:
is_latest:
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras: vllm
is_latest: true
- cuda: 126
cuda_version: 12.6.3
python_version: "3.11"
pytorch: 2.7.1
axolotl_extras: vllm
is_latest: true
🤖 Prompt for AI Agents 
In .github/workflows/main.yml around lines 160 to 171, remove the matrix entry
for PyTorch 2.7.1 on CUDA 12.6.3 that does not include the vllm variant, as the
build-axolotl job only supports the vllm variant for this configuration and the
non-vllm entry will fail to resolve BASE_TAG. Keep only the entry with
axolotl_extras set to vllm and is_latest set to true.

runs-on: axolotl-gpu-runner
steps:
- name: Checkout
Expand Down