Skip to content

use skip_move_to_device for all cases #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winglian merged 2 commits into from
Aug 6, 2025
Merged

use skip_move_to_device for all cases #3015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
788d50a
use skip_move_to_device for all cases
winglian Aug 5, 2025
1561fe6
use experimental option for skip move
winglian Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/axolotl/loaders/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,9 @@ def _build_model(self) -> bool:
self.model._tp_size = self.cfg.tensor_parallel_size
self.model._device_mesh = self.model_kwargs["device_mesh"]

if self.cfg.experimental_skip_move_to_device is not None:
skip_move_to_device = self.cfg.experimental_skip_move_to_device

return skip_move_to_device

def _set_z3_leaf_modules(self):
Expand Down
8 changes: 8 additions & 0 deletions src/axolotl/utils/schemas/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ class ModelInputConfig(BaseModel):
json_schema_extra={"description": "Trust remote code for untrusted source"},
)

experimental_skip_move_to_device: bool | None = Field(
default=None,
json_schema_extra={
"description": "Don't move the model to the device before sharding. "
"This is an experimental feature that may be included in the future as the default."
},
)

@field_validator("trust_remote_code")
@classmethod
def hint_trust_remote_code(cls, trust_remote_code):
Expand Down