feat: upgrade cce commit to include smollm3, granite, granitemoe#2993
Conversation
📝 WalkthroughWalkthroughThis change updates the Git commit hash used for installing the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
src/axolotl/integrations/cut_cross_entropy/__init__.py (1)
35-38: Same reproducibility concern as install script – please switch to the full 40-char commit hash here as well.src/axolotl/integrations/cut_cross_entropy/README.md (1)
22-23: Pin README install command to full commit hashFor the same reasons outlined in the install script comment, replace
@849c3c5with the complete commit id.
🧹 Nitpick comments (2)
src/axolotl/integrations/cut_cross_entropy/README.md (1)
44-46: Optional: keep model list alphabetically sorted for quick scanning
granite/granitemoewere added under the “g” block – good. Consider insertingsmollm3just after the other “s”-prefixed entries (currently none) and leavingvoxtrallast to keep strict lexicographic order.-61 - smollm3 -62 - voxtral +61 - smollm3 +62 - voxtral # already in correct spot if strict alpha order is enforcedPure readability polish; feel free to ignore if the current order has semantic meaning.
Also applies to: 61-62
examples/colab-notebooks/colab-axolotl-example.ipynb (1)
42-42: Consider pinningaxolotl[flash-attn]to an exact versionUsing
>=0.9.1means every future notebook run may silently pick a newer, potentially breaking release. If forward-compatibility is not guaranteed, lock to the specific version used when the notebook was authored.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
examples/colab-notebooks/colab-axolotl-example.ipynb(1 hunks)scripts/cutcrossentropy_install.py(1 hunks)src/axolotl/integrations/cut_cross_entropy/README.md(3 hunks)src/axolotl/integrations/cut_cross_entropy/__init__.py(1 hunks)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Summary by CodeRabbit
cut-cross-entropypackage to reference a newer version.granite,granitemoe,smollm3, andvoxtral.