Skip to content

feat: upgrade cce commit to include smollm3, granite, granitemoe#2993

Merged
winglian merged 1 commit into
mainfrom
feat/cce-upgrade
Jul 31, 2025
Merged

feat: upgrade cce commit to include smollm3, granite, granitemoe#2993
winglian merged 1 commit into
mainfrom
feat/cce-upgrade

Conversation

@NanoCode012
Copy link
Copy Markdown
Collaborator

@NanoCode012 NanoCode012 commented Jul 31, 2025

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

  • Documentation
    • Updated installation instructions for the cut-cross-entropy package to reference a newer version.
    • Expanded the list of supported models to include granite, granitemoe, smollm3, and voxtral.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 31, 2025

📝 Walkthrough

Walkthrough

This change updates the Git commit hash used for installing the cut-cross-entropy[transformers] package in multiple locations, including documentation, scripts, and a Colab notebook. Additionally, the list of supported models in the relevant README is expanded with four new entries.

Changes

Cohort / File(s) Change Summary
Update install hash in documentation and code
examples/colab-notebooks/colab-axolotl-example.ipynb, scripts/cutcrossentropy_install.py, src/axolotl/integrations/cut_cross_entropy/__init__.py
Updated the Git commit hash for the cut-cross-entropy[transformers] package installation command.
Expand supported models and update install hash in README
src/axolotl/integrations/cut_cross_entropy/README.md
Updated the install command with the new commit hash and added four models (granite, granitemoe, smollm3, voxtral) to the supported models list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

scheduled_release, ready to merge

Suggested reviewers

  • winglian

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/cce-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (2)
src/axolotl/integrations/cut_cross_entropy/__init__.py (1)

35-38: Same reproducibility concern as install script – please switch to the full 40-char commit hash here as well.

src/axolotl/integrations/cut_cross_entropy/README.md (1)

22-23: Pin README install command to full commit hash

For the same reasons outlined in the install script comment, replace @849c3c5 with the complete commit id.

🧹 Nitpick comments (2)
src/axolotl/integrations/cut_cross_entropy/README.md (1)

44-46: Optional: keep model list alphabetically sorted for quick scanning

granite/granitemoe were added under the “g” block – good. Consider inserting smollm3 just after the other “s”-prefixed entries (currently none) and leaving voxtral last to keep strict lexicographic order.

-61 - smollm3
-62 - voxtral
+61 - smollm3
+62 - voxtral   # already in correct spot if strict alpha order is enforced

Pure readability polish; feel free to ignore if the current order has semantic meaning.

Also applies to: 61-62

examples/colab-notebooks/colab-axolotl-example.ipynb (1)

42-42: Consider pinning axolotl[flash-attn] to an exact version

Using >=0.9.1 means every future notebook run may silently pick a newer, potentially breaking release. If forward-compatibility is not guaranteed, lock to the specific version used when the notebook was authored.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb1cae1 and 76bf20f.

📒 Files selected for processing (4)
  • examples/colab-notebooks/colab-axolotl-example.ipynb (1 hunks)
  • scripts/cutcrossentropy_install.py (1 hunks)
  • src/axolotl/integrations/cut_cross_entropy/README.md (3 hunks)
  • src/axolotl/integrations/cut_cross_entropy/__init__.py (1 hunks)

Comment thread examples/colab-notebooks/colab-axolotl-example.ipynb
Comment thread scripts/cutcrossentropy_install.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@winglian winglian merged commit eb0a8a7 into main Jul 31, 2025
22 of 23 checks passed
@winglian winglian deleted the feat/cce-upgrade branch July 31, 2025 22:18
This was referenced Aug 5, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Aug 27, 2025
2 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Dec 3, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants