Skip to content

fix xformers version#2888

Merged
winglian merged 1 commit into
mainfrom
xformers-version
Jul 9, 2025
Merged

fix xformers version#2888
winglian merged 1 commit into
mainfrom
xformers-version

Conversation

@winglian
Copy link
Copy Markdown
Collaborator

@winglian winglian commented Jul 9, 2025

Summary by CodeRabbit

  • Chores

    • Expanded test coverage to include PyTorch version 2.7.0.
  • Bug Fixes

    • Improved compatibility by adjusting the required version of a dependency based on the installed PyTorch 2.7.x patch version.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 9, 2025

Walkthrough

The changes update the CI workflow to test against PyTorch version 2.7.0 in addition to existing versions. In the setup script, the logic for selecting the "xformers" dependency is refined: for torch 2.7.x, version 0.0.30 is selected if the patch is zero, otherwise 0.0.31.post1 is used.

Changes

File(s) Change Summary
.github/workflows/tests.yml Added PyTorch version 2.7.0 to the test matrix for pytest and pytest-sdist jobs.
setup.py Adjusted logic to select xformers version based on torch 2.7.x patch version (0 vs nonzero).

Poem

In the burrows of code, a torchlight shines bright,
Now 2.7.0 joins the testing flight.
With xformers picked by patchy decree,
Rabbits hop forward, dependencies set free.
CI hops higher, dependencies align—
All's well in the warren, the codebase is fine!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ed501f and a390bad.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml (2 hunks)
  • setup.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: PyTest from Source Dist (3.11, 2.7.0)
  • GitHub Check: PyTest from Source Dist (3.11, 2.6.0)
  • GitHub Check: PyTest from Source Dist (3.11, 2.7.1)
  • GitHub Check: PyTest from Source Dist (3.11, 2.5.1)
  • GitHub Check: PyTest (3.11, 2.6.0)
  • GitHub Check: PyTest (3.11, 2.7.0)
  • GitHub Check: PyTest (3.11, 2.7.1)
  • GitHub Check: PyTest (3.11, 2.5.1)
  • GitHub Check: pre-commit
  • GitHub Check: pre-commit
🔇 Additional comments (3)
setup.py (1)

69-72: Document and validate xformers 0.0.31.post1 support for PyTorch 2.7.1

The logic in setup.py correctly pins:

  • torch 2.7.0 → xformers==0.0.30
  • torch 2.7.1+ → xformers==0.0.31.post1

However, official release notes and binary wheels for xformers 0.0.31.post1 only list support for PyTorch 2.7.0. There’s no explicit confirmation for 2.7.1, so please:

  • In setup.py lines 69–72, add a comment clarifying that 0.0.31.post1 is officially tested on 2.7.0 and assumed to work on 2.7.1.
  • Run integration tests (or smoke tests) against torch==2.7.1 to ensure xformers 0.0.31.post1 installs and functions correctly.
  • If you encounter issues, consider pinning both patch versions to xformers==0.0.30 or introducing a separate branch for 2.7.1.
.github/workflows/tests.yml (2)

55-55: Good addition for comprehensive test coverage.

Adding torch 2.7.0 to the test matrix ensures that the new conditional xformers version logic in setup.py is properly tested, particularly the patch==0 branch that selects xformers==0.0.30.


128-128: Consistent test matrix update.

The addition of torch 2.7.0 to the pytest-sdist job maintains consistency with the pytest job and ensures comprehensive testing coverage across both test scenarios.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@winglian winglian merged commit 4ff96a2 into main Jul 9, 2025
12 of 17 checks passed
@winglian winglian deleted the xformers-version branch July 9, 2025 12:43
@coderabbitai coderabbitai Bot mentioned this pull request Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant