-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
release v0.11.0 #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v0.11.0 #2875
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ Features: | |
|
|
||
| - NVIDIA GPU (Ampere or newer for `bf16` and Flash Attention) or AMD GPU | ||
| - Python 3.11 | ||
| - PyTorch ≥2.5.1 | ||
| - PyTorch ≥2.6.0 | ||
|
Comment on lines
56
to
+58
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainEnsure all residual references to PyTorch 2.5.1 are removed across the repo The bump to “PyTorch ≥ 2.6.0” looks correct here, but stray mentions of 2.5.1 in docs, scripts, or CI can confuse users. Run the following to confirm there are no leftover references: 🏁 Script executed: #!/bin/bash
# Search the entire repository for any remaining 2.5.1 mentions
rg -n "2\.5\.1"Length of output: 773 Update all residual PyTorch 2.5.1 references to ≥ 2.6.0 The bump in README.md is correct, but we still have a few stray “2.5.1” mentions that need updating:
After making these changes, please rerun rg -n "2\.5\.1"to ensure no leftovers. 🧰 Tools🪛 LanguageTool[grammar] ~58-~58: There might be a problem here. (QB_NEW_EN_MERGED_MATCH) 🤖 Prompt for AI Agents |
||
|
|
||
| ### Installation | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ | |
| "deepseek_v3", | ||
| "glm", | ||
| "glm4", | ||
| "smollm3", | ||
| ] | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -627,7 +627,7 @@ class AxolotlInputConfig( | |||||||||||||||||||||||||||||
| torch_compile: Literal["auto"] | bool | None = Field( | ||||||||||||||||||||||||||||||
| default=None, | ||||||||||||||||||||||||||||||
| json_schema_extra={ | ||||||||||||||||||||||||||||||
| "description": "Whether to use torch.compile and which backend to use. setting to `auto` will enable torch compile when torch>=2.5.1" | ||||||||||||||||||||||||||||||
| "description": "Whether to use torch.compile and which backend to use. setting to `auto` will enable torch compile when torch>=2.6.0" | ||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||
|
Comment on lines
+630
to
631
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docstring updated but validation logic still checks for ≥ 2.5.1 The - ) >= version.parse("2.5.1"):
+ ) >= version.parse("2.6.0"):📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need the version check anymore?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainLet me investigate the codebase to better understand the usage patterns and determine if the version check is still necessary. 🏁 Script executed: Length of output: 24617 @salmanmohammadi Based on the codebase analysis, you raise a valid question. Let me examine the current situation: Current state:
The version check in
@model_validator(mode="before")
@classmethod
def check_torch_compile_auto(cls, data):
if data.get("torch_compile") == "auto":
LOG.info("torch.compile is available, setting torch_compile to True")
data["torch_compile"] = True
return data
However, there are reasons to keep it:
My recommendation: Update the version check to use 2.6.0 (matching the minimum requirement) rather than removing it entirely. This maintains the safety net while being consistent with the new minimum version: ) >= version.parse("2.6.0"):What's your preference? Would you like to simplify/remove the check entirely, or just update it to 2.6.0? 🧬 Code Graph Analysis ResultsRelevant snippets from
|
||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||
| torch_compile_backend: str | None = Field( | ||||||||||||||||||||||||||||||
|
|
@@ -1083,9 +1083,9 @@ def check_beta_and_trl_beta_match(cls, data): | |||||||||||||||||||||||||||||
| def check_min_torch_version(self): | ||||||||||||||||||||||||||||||
| if self.env_capabilities and self.env_capabilities.torch_version: | ||||||||||||||||||||||||||||||
| torch_version = self.env_capabilities.torch_version | ||||||||||||||||||||||||||||||
| if version.parse(torch_version) < version.parse("2.5.1"): | ||||||||||||||||||||||||||||||
| if version.parse(torch_version) < version.parse("2.6.0"): | ||||||||||||||||||||||||||||||
| LOG.warning( | ||||||||||||||||||||||||||||||
| f"torch=={torch_version} may not be supported in future versions. Please consider upgrading to torch>=2.5.1." | ||||||||||||||||||||||||||||||
| f"torch=={torch_version} not be supported. Please upgrade to torch>=2.6.0." | ||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| return self | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳