-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
models.py -> loaders/ module refactor #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e700b39
models.py -> loaders/ module refactor
djsaunde d94bdf8
refactor ModelLoader class
djsaunde 2fb56ee
plugin manager changes
djsaunde 2f21fba
circular import fix
djsaunde ead5488
pytest
djsaunde e2c121d
pytest
djsaunde 4797364
minor improvements
djsaunde e20d574
fix
djsaunde 9216879
minor changes
djsaunde b5fb752
fix test
djsaunde 2b746dc
remove dead code
djsaunde 8e83559
coderabbit comments
djsaunde d7fafff
lint
djsaunde e72cea1
fix
djsaunde 5d5e3da
coderabbit suggestion I liked
djsaunde 4104596
more coderabbit
djsaunde ae8ad8a
review comments, yak shaving
djsaunde 5ac8de0
lint
djsaunde 5ddff2d
updating in light of SP ctx manager changes
djsaunde 0ad30db
review comment
djsaunde c157d51
review comment 2
djsaunde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.