filterx/expr-function: simple functions should get unmarshalled values #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, arguments to simple functions are evaluated at the time of the call, but that means that FilterXMessageValue objects are encountered when evaluating them. This is: 1) inconvinient, as we have to consider both native objects and message values 2) somewhat incorrect, as the unmarshalled version of the arguments are not cached in a filterx variable. 3) if the function changes the copy, it will not be impacting the filterx variable, e.g. unset_empties($json) will be a noop, if $json is an LM_VT_JSON I understand this may have a performance impact, but if it does, we can look into creating FilterXStrings with a borrowed string pointer. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-simple-func-should-get-eval-typed-args
branch
from
d0212e7 to
6972cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, arguments to simple functions are evaluated at the time of the call, but that means that FilterXMessageValue objects are encountered when evaluating them.
This is:
message values
not cached in a filterx variable.
filterx variable, e.g. unset_empties($json) will be a noop, if $json
is an LM_VT_JSON
I understand this may have a performance impact, but if it does, we can look into creating FilterXStrings with a borrowed string pointer.