filterx: fix switch eval errors #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Szakacs <[email protected]>
bazsi
reviewed
Feb 25, 2025
lib/filterx/expr-switch.c
Outdated
| @@ -187,8 +187,18 @@ _find_matching_case(FilterXSwitch *self, FilterXObject *selector) | |||
| FilterXSwitchCase *switch_case = (FilterXSwitchCase *) g_ptr_array_index(self->cases, i); | |||
|
|
|||
| FilterXObject *value = _eval_switch_case(switch_case); | |||
| if (!value) | |||
| { | |||
| filterx_object_unref(value); | |||
There was a problem hiding this comment.
this is not needed, as value is NULL
bazsi
previously approved these changes
Feb 25, 2025
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
filterx-fix-switch-eval-errors
branch
from
70de69f to
0be2bd2
Compare
|
@bazsi True, I updated the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.