WIP: the tip of my filterx performance efforts #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-perf-project
branch
4 times, most recently
from
6e3ce03 to
0b045c1
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
3 times, most recently
from
fbff61c to
5cab36c
Compare
This was referenced Jan 7, 2025
Merged
bazsi
force-pushed
the
filterx-perf-project
branch
6 times, most recently
from
d940c50 to
89e67ad
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
4 times, most recently
from
5be65da to
706b176
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
5 times, most recently
from
441b84d to
7beb087
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
3 times, most recently
from
7b7511f to
444d2ca
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
from
444d2ca to
6a704c7
Compare
Just like Python, sometimes we want to turn an object into a string to add it to trace messages (repr) indended to the developer, in other cases we want a simpler string representation aimed at customers (str). This patch adds str() in addition to the existing repr(). If str() is not implemented it defaults to using repr, so defaults doing the same as today. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Generator expressions either require a data structure on the LHS of an expression, or it uses a default storage mechanism, which was json() prior to this patch. Change these defaults to dict/list as appropriate. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
This change will cause all json() invocations to use the new native dictionary/list. Signed-off-by: Balazs Scheidler <[email protected]>
Instead of the JSON counterparts. Signed-off-by: Balazs Scheidler <[email protected]>
A scope is only considered dirty if it has message-tied variables that are changed. In any other case it's not dirty, so no sync is needed. Signed-off-by: Balazs Scheidler <[email protected]>
This reverts commit 12119c2.
This reverts commit 924c3a8e70e94151da903c533ac6ad7e61c06e30.
This is probably the next most accessed field in that struct. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
This reverts commit c2215ffe5c8fe0c28a59ead7bc071827e9d335ad.
This reverts commit 350c1cab2e643d12c280c7df0e402e96694f72e2.
bazsi
force-pushed
the
filterx-perf-project
branch
from
6a704c7 to
dfdb06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore this PR as it is not intended to be merged. It contains work-in-progress local patches I am yet to extract into separate pull requests.
It is rebased on top of my local merge of all related PRs, so I can maintain those branches separately as they get merged.