python 3.11 && test module #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test module adds an example user to the given survey and sends notifications
axnsantana
reviewed
Dec 21, 2023
Owner
axnsantana
left a comment
axnsantana
left a comment
There was a problem hiding this comment.
Thank you for the pull request updating the tool for a new python version.
I left some small comments
| method = "get_survey_properties" | ||
| print params | ||
| r = self.call_rpc(method,params) | ||
Owner
There was a problem hiding this comment.
This is not going to work, syntax error.
| print "Params before: %s" % params | ||
| params = self.__sort_params(method,params) | ||
| print "Params sorted: %s" % params | ||
| print("Method: %s" % method) |
Owner
There was a problem hiding this comment.
A good idea is to already update to use f-strings, for example: print(f"Method: {method}")
Owner
|
I just update the code from 2.7 to new python versions 3.10. You can complement it with the tests and other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test module adds an example user to the given survey and sends notifications
print change for python 3
similarly to the items enumerator for parameters