Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect static value usage in JNI array methods #2178

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Sep 24, 2024

Describe your changes

Refer to issue #2175 for the discussion regarding this issue.

JNI helper methods should not be caching data.

Use axstd::pod_vector instead of raw pointers to array data for callStaticIntArrayMethod and callStaticFloatArrayMethod. Array size is no longer limited to 32 items.

Issue ticket number and link

#2175

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.2 milestone Sep 24, 2024
@halx99 halx99 linked an issue Sep 24, 2024 that may be closed by this pull request
@halx99 halx99 merged commit dfab7a3 into axmolengine:dev Sep 24, 2024
15 checks passed
@rh101 rh101 deleted the fix-issue2175 branch September 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android getSafeAreaRect() Wrong values
2 participants