Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (missing) parameter 'drawLineToCenter' to 'drawSolidCircle(...)' #2160

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

aismann
Copy link
Contributor

@aismann aismann commented Sep 17, 2024

Describe your changes

Add parameter drawLineToCenter to drawSolidCircle:
image

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@aismann aismann marked this pull request as draft September 17, 2024 04:54
@aismann
Copy link
Contributor Author

aismann commented Sep 17, 2024

Add drawSolidTriangle(...)
image

@aismann
Copy link
Contributor Author

aismann commented Sep 17, 2024

@halx99
Please merge it.

@aismann aismann marked this pull request as ready for review September 17, 2024 09:02
@halx99 halx99 added this to the 2.2.0 milestone Sep 17, 2024
@halx99 halx99 merged commit c488380 into axmolengine:dev Sep 17, 2024
15 checks passed
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
…xmolengine#2160)

* Add parameter drawLineToCenter to drawSolidCircle

* fix  drawSolidTringle/drawTriangle

* Update axlua_base_auto.cpp
xfbird pushed a commit to xfbird/axmol that referenced this pull request Sep 18, 2024
…xmolengine#2160)

* Add parameter drawLineToCenter to drawSolidCircle

* fix  drawSolidTringle/drawTriangle

* Update axlua_base_auto.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants