Allow turn on/off deprecated features #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halx99
changed the title
Closed
solan-solan
approved these changes
Sep 11, 2024
halx99
force-pushed
the
allow-turn-onoff-deprecated-features
branch
from
8e40a35
to
3d8b23a
Compare
|
How will future "AX_DEPRECATED_ATTRIBUTE" features handle? If I have AX_DISABLE_DEPRECATED = 'true' => all new defined "AX_DEPRECATED_ATTRIBUTE" features will be "removed" directly without planed version? Ok I have this reading to late: |
smilediver
reviewed
Sep 12, 2024
halx99
force-pushed
the
allow-turn-onoff-deprecated-features
branch
2 times, most recently
from
4c5eb70
to
e10611c
Compare
- Add new cmake option: AX_CORE_PROFILE
halx99
force-pushed
the
allow-turn-onoff-deprecated-features
branch
from
e10611c
to
b07c4c5
Compare
xfbird
pushed a commit
to xfbird/axmol
that referenced
this pull request
Sep 18, 2024
…engine#2136) - Add new cmake option: `AX_CORE_PROFILE` - Remove deprecated stubs from extension: `cocostudio` - Remove `AX_DEPRECATED_ATTRIBUTE`
xfbird
pushed a commit
to xfbird/axmol
that referenced
this pull request
Sep 18, 2024
…engine#2136) - Add new cmake option: `AX_CORE_PROFILE` - Remove deprecated stubs from extension: `cocostudio` - Remove `AX_DEPRECATED_ATTRIBUTE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
AX_CORE_PROFILEcocostudioAX_DEPRECATED_ATTRIBUTEIssue ticket number and link
#2111
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR