Add support for ensuring sprite content size does not change on new texture #1897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If a sprite is to be used for animations (such as the
Animate
action), and a specific sprite content size is set (usually with stretch mode enabled), then this adds support for ensuring that the content size of the sprite is not modified during the animation.An explicit call to
setContentSize
will still work, but setting new textures on the sprite will not affect the content size due to this change:The added method is:
I'm not completely sure about the naming of that method,
setContentSizeDynamic
, so if anyone has any alternate suggestions, then please put them forward. It should be something that indicates the sprite content size is not affected by new content (being a new texture etc.).Also note that existing behaviour does not change, since the default is
_contentSizeDynamic = true
.Issue ticket number and link
#1896
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR