Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileUtilsApple::getPathForDirectory() checking wrong path #1828

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

smilediver
Copy link
Contributor

Describe your changes

FileUtilsApple::getPathForDirectory() is checking the given directory without appending a search path. This fixes it.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 merged commit 37d9a0d into axmolengine:dev Apr 17, 2024
14 of 15 checks passed
@halx99 halx99 added this to the 2.1.3 milestone Apr 17, 2024
@halx99 halx99 added the bug Something isn't working label Apr 17, 2024
@smilediver smilediver deleted the fix_fileutils branch April 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants