Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add Borderless Windowed Mode #1826

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

TyelorD
Copy link
Contributor

@TyelorD TyelorD commented Apr 16, 2024

Describe your changes

This PR adds borderless windowed mode support to the GLViewImpl class. For backwards compatibility the setWindowed function uses a default parameter of 'false' for borderless.

Issue ticket number and link

N/A

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

This PR adds borderless windowed mode support to the GLViewImpl class. For backwards compatibility the setWindowed function uses a default parameter of 'false' for borderless.
@halx99 halx99 merged commit 7a9dea4 into axmolengine:dev Apr 17, 2024
14 of 15 checks passed
@halx99 halx99 added this to the 2.1.3 milestone Apr 17, 2024
@halx99 halx99 added the enhancement New feature or request label Apr 17, 2024
@TyelorD TyelorD deleted the add-borderless-windowed-mode branch April 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants