RichText and ScrollView enhancements #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for the "id" attribute to
RichText
XML anchor, paragraph, header and custom tags. The ID is saved as the name of the node (viasetName()
).Add support for adjusting font/size/color of paragraph elements in RichText.
Move scroll to item support from
ListView
to the base classScrollView
, since it applies toScrollView
nodes as well.Add support for finding a protected node in a
ScrollView
via the name.All of the above changes can be combined together when a
RichText
is child of aScrollView
, allowing the user to click on a link that takes them directly to another section of theRichText
(scrolling theScrollView
to that point).For example, taking this input:
A test case showcasing this functionality has been added to the
cpp-tests
project (RichText test 22).This functionality should not impact any existing usage of ScrollView, ListView or RichText.
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR