Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add missing return statement #1657

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Feb 6, 2024

Which branch your pull-request should merge into?

  • 2.1: BugFixes and Improvements for Current LTS branch

Describe your changes

Return statement is missing from the _tWinMain method, causing inaccurate exit codes to be outputted on program exit.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 merged commit b4877b4 into axmolengine:2.1 Feb 6, 2024
7 of 8 checks passed
@halx99 halx99 added this to the 2.1.2 milestone Feb 6, 2024
@rh101 rh101 deleted the fix-main-return branch February 6, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants