Call Android native renderer while opengl context is still valid #1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which branch your pull-request should merge into?
dev
: Current 2.x BugFixs or FeaturesDescribe your changes
This change is part of a combination of changes that are required to ensure that the Android application does not crash due to an invalid OpenGL context.
The specific issue this PR addresses is that the Android native render was being called after a
Thread.sleep
, at which point the OpenGL context may not be valid. This may be because of the app going to the background (for example, during a phone call etc.) during theonDrawFrame
call, just prior to it exiting theThread.sleep
, and if for any reason Android invalidates the OpenGL context, this would cause a crash.Issue ticket number and link
#1211
Checklist before requesting a review