Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate lua from 5.1~5.3.x to 5.4.x #332

Closed
5 tasks done
aismann opened this issue Mar 15, 2021 · 4 comments · Fixed by #520
Closed
5 tasks done

Migrate lua from 5.1~5.3.x to 5.4.x #332

aismann opened this issue Mar 15, 2021 · 4 comments · Fixed by #520
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
1.0.0

Comments

@aismann
Copy link
Contributor

aismann commented Mar 15, 2021 •
edited by halx99
Loading

  • unpack, pack moved from global to package table
  • math.pow was removed, use operator ^ instead
  • Use # instead table.getn
  • Since lua-5.1 math.mod was renamed to math.fmod, the behavior same with operator %
  • Remove any garbage collection settings in lua code
@halx99
Copy link
Collaborator

halx99 commented Mar 15, 2021

I have run the lua-tests project with lua5.4.2, the performance is very slow when scroll the main menu panel, so it may needs a long time to determine whether upgrade to lua5.4.x

@halx99
Copy link
Collaborator

halx99 commented Mar 27, 2021

Note: By profile with visualstudio, it may caused by incorrect gc mode set

@halx99 halx99 added this to the 1.0 milestone Mar 27, 2021
@halx99 halx99 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 27, 2021
@halx99
Copy link
Collaborator

halx99 commented Mar 27, 2021 •
edited
Loading

Actually, axmol support simply switch plain lua version with follow steps:

  1. unzip lua-5.4.3.tar.gz and copy folder lua-5.4.3 to thirdparty/lua/plainlua/
  2. Add "-DLUA_VERSION=5.4.3" when use cmake to generate project files

@halx99
Copy link
Collaborator

halx99 commented Oct 8, 2021

https://eklausmeier.wordpress.com/2020/05/14/performance-comparison-pallene-vs-lua-5-1-5-2-5-3-5-4-vs-c/

@halx99 halx99 changed the title Lua 5.4.3 is on the start (lua-5.4.3-rc2.tar.gz 2021-03-15) Migrate lua from 5.3.x to 5.4.x Oct 8, 2021
@halx99 halx99 pinned this issue Oct 8, 2021
halx99 added a commit that referenced this issue Oct 8, 2021
@halx99
Use lua-5.4.3 as default plainlua version
1ada732 
see also: #332
@halx99 halx99 mentioned this issue Oct 8, 2021
Merged
@halx99 halx99 linked a pull request Oct 8, 2021 that will close this issue
Use lua-5.4.3 as default plainlua version #520
Merged
@halx99 halx99 changed the title Migrate lua from 5.3.x to 5.4.x Migrate lua from 5.1~5.3.x to 5.4.x Oct 24, 2021
@halx99 halx99 mentioned this issue Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Use lua-5.4.3 as default plainlua version axmolengine/axmol
2 participants
@halx99 @aismann