Fix return type when rejecting constant arrays

axlon · Sep 26, 2024 · 7689d95 · 7689d95
1 parent 4e3fa4e
commit 7689d95
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Type/PhpOption/TypeUtil.php b/src/Type/PhpOption/TypeUtil.php
@@ -21,7 +21,11 @@ public static function forShallowComparison(Type $type): Type
                 return $traverse($type);
             }
 
-            return $type->isConstantScalarValue()->yes() ? $type : new NeverType();
+            if ($type->isConstantScalarValue()->yes() || $type->isConstantArray()->yes()) {
+                return $type;
+            }
+
+            return new NeverType();
         });
     }
 }
diff --git a/tests/Type/PhpOption/data/option-reject.php b/tests/Type/PhpOption/data/option-reject.php
@@ -7,6 +7,13 @@
 /**
  * @var \PhpOption\Option<string|null> $option
  */
+assertType('PhpOption\Option<non-empty-string|null>', $option->reject(''));
 assertType('PhpOption\Option<string|null>', $option->reject('string'));
 assertType('PhpOption\Option<string|null>', $option->reject(123));
 assertType('PhpOption\Option<string>', $option->reject(null));
+
+/**
+ * @var \PhpOption\Option<array<string>> $option
+ */
+assertType('PhpOption\Option<non-empty-array<string>>', $option->reject([]));
+assertType('PhpOption\Option<array<string>>', $option->reject(''));