Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet hook field can contain split UTF-8 character. #404

Closed
baiomys opened this issue Dec 9, 2024 · 3 comments
Closed

Snippet hook field can contain split UTF-8 character. #404

baiomys opened this issue Dec 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@baiomys
Copy link

baiomys commented Dec 9, 2024

In this case it ends with �...

=)

@axllent
Copy link
Owner

axllent commented Dec 10, 2024

Thank you, good catch! To replicate this the UFT-8 character must be exactly on the 200-character limit, so I am not surprised nobody has ever noticed (or reported) this before.

I have pushed a fix for this, although I'm not exactly sure when a new release will come out as I will be recovering from shoulder surgery. I think I should be able to get a release out within a week or two though 🤞

@axllent axllent added the bug Something isn't working label Dec 10, 2024
@baiomys
Copy link
Author

baiomys commented Dec 10, 2024

Get well soon!
Bug is definitely not serious, just a bit annoying, no need to rush.

@baiomys baiomys closed this as completed Dec 10, 2024
@axllent
Copy link
Owner

axllent commented Dec 14, 2024

This has now been released in v1.21.7. Thanks again for the bug report.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Dec 20, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [axllent/mailpit](https://github.com/axllent/mailpit) | patch | `v1.21.6` -> `v1.21.8` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>axllent/mailpit (axllent/mailpit)</summary>

### [`v1.21.8`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1218)

[Compare Source](axllent/mailpit@v1.21.7...v1.21.8)

##### Chore

-   Update node dependencies
-   Update Go dependencies

##### Fix

-   **db:** Remove unused FOREIGN KEY REFERENCES in message_tags table ([#&#8203;374](axllent/mailpit#374))

### [`v1.21.7`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1217)

[Compare Source](axllent/mailpit@v1.21.6...v1.21.7)

##### Chore

-   Update node dependencies
-   Update Go dependencies
-   Bump Go version for automated testing
-   Move smtpd & pop3 modules to internal
-   Stricter SMTP 'MAIL FROM' & 'RCPT TO' handling ([#&#8203;409](axllent/mailpit#409))
-   Display "To" details in mobile messages list
-   Display "From" details in message sidebar (desktop) ([#&#8203;403](axllent/mailpit#403))

##### Fix

-   Ignore unsupported optional SMTP 'MAIL FROM' parameters ([#&#8203;407](axllent/mailpit#407))
-   Prevent splitting multi-byte characters in message snippets ([#&#8203;404](axllent/mailpit#404))

##### Testing

-   Add smtpd tests

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS42NC4wIiwidXBkYXRlZEluVmVyIjoiMzkuNzUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants