Email decoding issue

[D3strukt0r]

Hello, we have been trying to figure out for hours now if an email we are sending from our backend is sending the email faulty or if it's mailpit display that's broken, and after rigorous testing we figured something is off with mailpit

Here are a working case (any length shorter or equal to this will work)

example-works.eml.txt

And an example where anything longer or equal to this length (not sure if this is actually true) will break

example-broken.eml.txt

when being sent to any other mailcatcher software or opening in MS Outlook, it is displayed correctly

I hope this can help you identify the issue :)

PS: I tested with Mailpit v1.20.1

[axllent]

@D3strukt0r I can confirm the decoding issue using your sample messages, and I can also confirm that this is originating "upstream" in the jhillyerd/enmime module (which Mailpit uses to decode messages). I was able to replicate it with a simple test to rule out that it is related in any way to Mailpit (see below).

What I can't confirm is whether it has anything to do with your message encoding / structure (I cannot see any obvious issue). It is very strange how just a slight change causes the issue, so it appears to be a possible issue with jhillyerd/enmime.

main.go

package main

import (
	"bufio"
	"fmt"
	"os"

	"github.com/jhillyerd/enmime"
)

func main() {
	if len(os.Args) != 2 {
		fmt.Printf("usage: %s <message>\n", os.Args[0])
		os.Exit(1)
	}

	file, err := os.Open(path.Clean(os.Args[1]))
	if err != nil {
		fmt.Println(err.Error())
		os.Exit(1)
	}

	defer file.Close()

	r := bufio.NewReader(file)

	env, err := enmime.ReadEnvelope(r)
	if err != nil {
		fmt.Println(err.Error())
		os.Exit(1)
	}

	fmt.Println("## TEXT ##")
	fmt.Println(env.Text)
	fmt.Println("## HTML ##")
	fmt.Println(env.HTML)
}

Working example:

go run . example-works.eml.txt 
## TEXT ##
Loggen Sie sich ein, um die Einladung zu akzeptieren oder geben Sie den folge

Nachricht:
öoöo

## HTML ##
    Loggen Sie sich ein, um die Einladung zu akzeptieren oder geben <br />
    <br />Nachricht:<br />
öoöo<br />

Broken example:

go run . example-broken.eml.txt 
## TEXT ##
Loggen Sie sich ein, um die Einladung zu akzeptieren oder geben Sie den folgen

Nachricht:
öoöo

## HTML ##
    Loggen Sie sich ein, um die Einladung zu akzeptieren oder geben S<br />
    <br />Nachricht:<br />
öoöo<br />

My suggestion would be for you to report the issue to jhillyerd/enmime and hopefully someone there can either confirm (and potentially fix) the issue, or explain why your message is causing this. It may be useful to reference this issue to save them time.

[axllent]

I can confirm that I get the correct decoding using the default Go library, so I am almost 100% certain it's an upstream (enmime) issue. I will continue to investigate and see if I can find a workaround as I'm not entirely sure a fix will come any time soon.

[axllent]

I've found the reason why this happens (commented on in the issue you reported) - will wait for a response to try understand why before I look at a solution (assuming it's not a bug).

[axllent]

@D3strukt0r I have just released v1.20.3 which should provide a solution for your issue. Please confirm it is working correctly for you now? Thanks.

[D3strukt0r]

@axllent yes seems to be working fine for me now :)

thank you a lot <3

[axllent]

That's fantastic, thank you for the feedback.