This pull request addresses the issue where the eact-multi-email com… #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent does not respect custom email validation. The fix ensures that the component respects the user's custom validation by modifying and moving the initialEmailAddress function to prioritize the provided custom validation over the internal validation. Additionally, tests have NOT been updated to cover the fixed behavior. Please review and merge at your earliest convenience. Thank you!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…returning the emails properly based on the validateEmail prop
…returning the emails properly based on the validateEmail prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Description:
The component doesn't respect custom email validation. To address this, I modified and relocated the initialEmailAddress function to prioritize the user's custom validation over the internal one. Additionally, I've added a test case to cover the fixed behavior. Please review and merge the changes at your earliest convenience. Thank you!
Changes Made:
Test Plan:
Please review and merge the changes at your earliest convenience. Thank you!
fix for this issue:
#170