Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #19

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Updates #19

merged 8 commits into from
Feb 21, 2024

Conversation

kthyng
Copy link
Member

@kthyng kthyng commented Feb 21, 2024

  • Now initialize all class attributes with None and removed usage of hasattr which simplifies and clarifies some code.
  • Improved handling of start_time, end_time, duration, and steps in manager.py which fixed a bug in which users couldn't input start_time and have the simulation run successfully.
  • simplified handling of horizontal_diffusivity in opendrift model.
  • user can change end_time, duration, and steps and have the others update accordingly. Tests added to check this.
  • changed known model "CIOFS_now" to "CIOFSOP" to avoid upper/lower issues and include "OP" for "operational".
  • many more tests and improved behavior for attribute checks and updates

@kthyng
WIP: changes to simplify and clean up
4d73289 
* removed hasattr's by initializing class attributes to None
* simplifying some of the logic (still in the works)
@kthyng
updates
c840d7a 
* to tests due to changes in steps initialized as None now instead of 3
* streamlined horizontal_diffusivity handling and had to update tests accordingly
* rearranged order of initialization a little
@kthyng
added tests for combination of inputs
20dcad6 
for end_time, steps, and duration.
@kthyng
stream-lined being able to change parameters...
5a56191 
end_time, duration, and steps and have the others update accordingly.
@kthyng
changed CIOFS_now to CIOFSOP to avoid issues
4983c87
@kthyng
added and updated lots of test
af1cef0
@kthyng
precommit and added appdirs to ci env files
90794f7
@kthyng
updated version
494ee81
@kthyng
Copy link
Member Author

kthyng commented Feb 21, 2024

I am going to merge this since it won't pass tests until a new version of opendrift is released.

@kthyng kthyng merged commit 3ae1faf into main Feb 21, 2024
2 of 11 checks passed
@kthyng kthyng deleted the updates branch February 21, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kthyng