[feat] update gen_dummy_snark to help with keygen#48
Merged
Conversation
This function does not need to know the `ConcreteCircuit` type
Trait to help keygen of aggregation circuits.
jonathanpwang
changed the title
gen_dummy_snark for circuit-paramsgen_dummy_snark to help with keygen
Also added `NativeKzgAccumulationScheme` trait
jonathanpwang
added a commit
that referenced
this pull request
Jan 18, 2024
- #37 Note on commit history: #37 was merged first into this branch at c7d7a8f, then some changes were made to `release-0.1.6-rc0`, so I rebased `release-0.1.6-rc0` onto this branch and force pushed. Utilities to generate dummy snarks to help with proving key generation of aggregation circuits: * #48 * #49 Merge after: - [x] v0.1.6 merged to main - [x] halo2-lib v0.4.1 merged to main
jonathanpwang
pushed a commit
that referenced
this pull request
Apr 26, 2024
jonathanpwang
added a commit
that referenced
this pull request
Apr 27, 2024
* chore: keep old behavior of `EccInstructions::sum_with_const` After axiom-crypto/halo2-lib#244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change. * chore: fix clap version to prevent rust version issues * ci: install `svm-rs` with its `Cargo.lock` (#48) * chore: use solc-select instead of svm to avoid rust version issues --------- Co-authored-by: Han <tinghan0110@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No circuit logic was changed.
gen_dummy_snarkneeds to account forConcreteCircuit::Paramswith the new feature"circuit-params"in halo2.gen_dummy_snark_from_vkthat gives a dummy snark with correct "shape" from vkey without knowledge of circuit type.gen_dummy_snark_from_protocolthat does same thing as above fromPlonkProtocolAggregationCircuit, for the purposes of keygen, from just verifying keys of dependencies.The idea is this should be used to implement
KeygenCircuitIntentfrom axiom-crypto/halo2-lib#227 but I don't do it here since the exactPinningtype may vary.