Skip to content

fix: cleanup code quality #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpwang merged 1 commit into from
May 22, 2023
Merged

fix: cleanup code quality #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions snark-verifier/src/loader/evm/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,9 @@ where
self.ec_point(Value::Constant((x, y)))
}

fn ec_point_assert_eq(&self, _: &str, _: &EcPoint, _: &EcPoint) {}
fn ec_point_assert_eq(&self, _: &str, _: &EcPoint, _: &EcPoint) {
unimplemented!()
}

fn multi_scalar_multiplication(
pairs: &[(&<Self as ScalarLoader<C::Scalar>>::LoadedScalar, &EcPoint)],
Expand All @@ -672,7 +674,9 @@ impl<F: PrimeField<Repr = [u8; 0x20]>> ScalarLoader<F> for Rc<EvmLoader> {
self.scalar(Value::Constant(fe_to_u256(*value)))
}

fn assert_eq(&self, _: &str, _: &Scalar, _: &Scalar) {}
fn assert_eq(&self, _: &str, _: &Scalar, _: &Scalar) {
unimplemented!()
}

fn sum_with_coeff_and_const(&self, values: &[(F, &Scalar)], constant: F) -> Scalar {
if values.is_empty() {
Expand Down
2 changes: 1 addition & 1 deletion snark-verifier/src/system/halo2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ pub fn compile<'a, C: CurveAffine, P: Params<'a, C>>(
.chain((0..num_proof).flat_map(move |t| polynomials.permutation_z_queries::<true>(t)))
.chain((0..num_proof).flat_map(move |t| polynomials.lookup_queries::<true>(t)))
.collect();

// `quotient_query()` is not needed in evaluations because the verifier can compute it itself from the other evaluations.
let queries = (0..num_proof)
.flat_map(|t| {
iter::empty()
Expand Down
Loading