feat: Add BLS signature verification for BN254#89
Merged
jonathanpwang merged 7 commits intoAug 10, 2023
Merged
Conversation
jonathanpwang
requested changes
Jul 22, 2023
jonathanpwang
left a comment
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
Some code quality comments and one change regarding add_unequal.
jonathanpwang
requested changes
Jul 25, 2023
jonathanpwang
left a comment
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the changes so quickly.
Some minor change around avoiding (0,0) identity point.
Also missed last time that this new function should be returning 0 or 1, not an Fp12 point.
jonathanpwang
requested changes
Aug 8, 2023
flyingnobita
commented
Aug 8, 2023
Contributor
|
LGTM |
jonathanpwang
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.