Skip to content

[Fix] scalar multiply completeness #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpwang merged 2 commits into from
Jun 9, 2023
Merged

[Fix] scalar multiply completeness #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f051b
fix: replace `scalar_multiply` with passthrough to MSM for now
jonathanpwang Jun 9, 2023
67f7084
feat(msm): use strict mode always
jonathanpwang Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions halo2-ecc/src/ecc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,8 @@ where
assert!(!scalar.is_empty());
assert!((max_bits as u64) <= modulus::<F>().bits());
assert!(window_bits != 0);

multi_scalar_multiply::<F, FC, C>(chip, ctx, &[P], vec![scalar], max_bits, window_bits)
/*
let total_bits = max_bits * scalar.len();
let num_windows = (total_bits + window_bits - 1) / window_bits;
let rounded_bitlen = num_windows * window_bits;
Expand Down Expand Up @@ -582,6 +583,7 @@ where
// if at the end, return identity point (0,0) if still not started
let zero = chip.load_constant(ctx, FC::FieldType::zero());
ec_select(chip, ctx, curr_point, EcPoint::new(zero.clone(), zero), *is_started.last().unwrap())
*/
}

/// Checks that `P` is indeed a point on the elliptic curve `C`.
Expand Down Expand Up @@ -734,7 +736,7 @@ where
ctx,
&rand_start_vec[k],
&rand_start_vec[0],
k >= F::CAPACITY as usize,
true, // k >= F::CAPACITY as usize, // this assumed random points on `C` were of prime order equal to modulus of `F`. Since this is easily missed, we turn on strict mode always
);
let mut curr_point = start_point.clone();

Expand Down