[chore] make KeccakComponentShardCircuit inputs into RefCell#231
Merged
Conversation
nyunyunyunyu
approved these changes
Dec 10, 2023
Merged
zemse
pushed a commit
to zemse/axiom-halo2-lib
that referenced
this pull request
Jan 19, 2024
In the future we will not squash merge so as to maintain history. ## Bug Fixes * axiom-crypto#224 ## Other PRs * axiom-crypto#218 * axiom-crypto#231 * axiom-crypto#232 * axiom-crypto#227 * axiom-crypto#235 * axiom-crypto#237 * axiom-crypto#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some downstream traits only borrow and not mutably borrow, but we want to be able to initialize the circuit first and then set the input later.
Also added a getter for
base_circuit_builder.