[chore] fix deref after using CopyGetters

halo2-base/src/poseidon/hasher/mod.rs

@@ -55,13 +55,13 @@ impl<F: ScalarField, const T: usize, const RATE: usize> PoseidonHasherConsts<F,
 /// 1 logical row of compact input for Poseidon hasher.
 #[derive(Copy, Clone, Debug, Getters, CopyGetters)]
 pub struct PoseidonCompactInput<F: ScalarField, const RATE: usize> {
-    // Right padded inputs. No constrains on paddings.
+    /// Right padded inputs. No constrains on paddings.
     #[getset(get = "pub")]
     inputs: [AssignedValue<F>; RATE],
-    // is_final = 1 triggers squeeze.
+    /// is_final = 1 triggers squeeze.
     #[getset(get_copy = "pub")]
     is_final: SafeBool<F>,
-    // Length of `inputs`.
+    /// Length of `inputs`.
     #[getset(get_copy = "pub")]
     len: AssignedValue<F>,
 }
@@ -94,10 +94,10 @@ impl<F: ScalarField, const RATE: usize> PoseidonCompactInput<F, RATE> {
 /// A compact chunk input for Poseidon hasher. The end of a logical input could only be at the boundary of a chunk.
 #[derive(Clone, Debug, Getters, CopyGetters)]
 pub struct PoseidonCompactChunkInput<F: ScalarField, const RATE: usize> {
-    // Inputs of a chunk. All witnesses will be absorbed.
+    /// Inputs of a chunk. All witnesses will be absorbed.
     #[getset(get = "pub")]
     inputs: Vec<[AssignedValue<F>; RATE]>,
-    // is_final = 1 triggers squeeze.
+    /// is_final = 1 triggers squeeze.
     #[getset(get_copy = "pub")]
     is_final: SafeBool<F>,
 }

halo2-base/src/poseidon/hasher/tests/hasher.rs

@@ -160,7 +160,7 @@ fn hasher_compact_chunk_inputs_compatiblity_verification<
     for (compact_output, chunk_input) in compact_outputs.iter().zip(chunk_inputs) {
         // into() doesn't work if ! is in the beginning in the bool expression...
         let is_final_input = chunk_input.is_final.as_ref().value();
-        let is_final_output = compact_output.is_final().as_ref().value();
+        let is_final_output = compact_output.is_final.as_ref().value();
         assert_eq!(is_final_input, is_final_output);
         if is_final_output == &Fr::ONE {
             assert_eq!(native_results[output_offset], *compact_output.hash().value());

hashes/zkevm/src/keccak/component/circuit/shard.rs

@@ -347,7 +347,7 @@ impl<F: Field> KeccakComponentShardCircuit<F> {
             lookup_key_per_keccak_f.iter().zip_eq(loaded_keccak_fs)
         {
             let is_final = AssignedValue::from(loaded_keccak_f.is_final);
-            let key = gate.select(ctx, *compact_output.hash(), dummy_key_witness, is_final);
+            let key = gate.select(ctx, compact_output.hash(), dummy_key_witness, is_final);
             let hash_lo =
                 gate.select(ctx, loaded_keccak_f.hash_lo, dummy_keccak_lo_witness, is_final);
             let hash_hi =

hashes/zkevm/src/keccak/component/encode.rs

@@ -123,7 +123,7 @@ pub fn encode_var_len_bytes_vec<F: Field>(
         initialized_hasher.hash_compact_chunk_inputs(ctx, range_chip.gate(), &chunk_inputs);
     range_chip.gate().select_by_indicator(
         ctx,
-        compact_outputs.into_iter().map(|o| *o.hash()),
+        compact_outputs.into_iter().map(|o| o.hash()),
         f_indicator,
     )
 }